Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Dry/wet control after output gain #69

Closed
darwindeez opened this issue Aug 16, 2020 · 15 comments · Fixed by #73
Closed

[FEATURE] Dry/wet control after output gain #69

darwindeez opened this issue Aug 16, 2020 · 15 comments · Fixed by #73
Assignees
Labels
enhancement New feature or request

Comments

@darwindeez
Copy link

darwindeez commented Aug 16, 2020

I would love to have the wet/dry AFTER the output gain, which I feel would be more useful for getting sounds. Getting sounds out of a nice sounding tape plugin such as Le Chow 5000 usually goes like this:

  1. tweak settings, listening only for tone, ignoring output level (since every tonal control affects output level). get a nice tone. get the tape to react to the source the way you want it to.
  2. match output level to input level to check that the tonal change is actually a nice improvement and not just louder (important step).
  3. dial in the actual desired amount of said tone using the wet/dry knob.

If the wet/dry is before the output level, I'm not able to fine tune my tonal change nearly as easily. Cool project!!

@darwindeez darwindeez added the enhancement New feature or request label Aug 16, 2020
@jatinchowdhury18 jatinchowdhury18 changed the title [FEATURE] [FEATURE] Dry/wet control after output gain Aug 16, 2020
@jatinchowdhury18
Copy link
Owner

jatinchowdhury18 commented Aug 16, 2020

Hi @darwindeez,

Thanks for the feature request. This seems pretty reasonable. Just to make sure I'm understanding the request correctly:

The current signal flow is as follows:
Input ---> | In Gain | ----> | Processing | -----> | Dry/Wet | ----> | Out Gain | ---> Output
          |            |
          --------> | Delay | ------------

What you're asking for would be:
Input ---> | In Gain | ----> | Processing | ----> | Out Gain | -----> | Dry/Wet | ---> Output
          |                    |
          --------> | Delay | -------------------------------

(apologies for the rough diagrams)

If we were to make that change, I suppose it might also make sense to include the Input Gain as part of the "wet" processing, though I'm not sure how useful that would be given the workflow that you described.

In case you're curious, the code that implements the signal flow is here.

Thanks,
Jatin

@darwindeez
Copy link
Author

darwindeez commented Aug 17, 2020 via email

@jatinchowdhury18
Copy link
Owner

Hi Darwin,

No problem! I think I'm going to go with the version that includes Input Gain as part of the "wet" processing. This signal flow looks like this:
Input ---> | In Gain | ----> | Processing | ----> | Out Gain | -----> | Dry/Wet | ---> Output
   |                           |
   --------------------------> | Delay | -------------------------------

If you want to try it out, I've made a version of the builds with this change:
CHOWTape-Win64-DryWet.zip

If you're on Mac let me know and I can generate some Mac builds for you to try.

Thanks,
Jatin

@jatinchowdhury18
Copy link
Owner

Hey @darwindeez, just wanted to check if you'd had a chance to test out the version that is shared above.

Thanks,
Jatin

@darwindeez
Copy link
Author

darwindeez commented Aug 22, 2020 via email

@jatinchowdhury18
Copy link
Owner

No problem! You can download updated Mac builds here.

@darwindeez
Copy link
Author

darwindeez commented Aug 23, 2020 via email

@jatinchowdhury18 jatinchowdhury18 linked a pull request Aug 23, 2020 that will close this issue
@jatinchowdhury18
Copy link
Owner

Ah, thanks for that update. I had made some internal changes, and had neglected to update the dry/wet latency compensation accordingly. This should be fixed in the new builds, which you can try out here.

@darwindeez
Copy link
Author

darwindeez commented Aug 23, 2020 via email

@jatinchowdhury18
Copy link
Owner

Okay great! I can tweak the latency compensation a tiny bit more to help alleviate the the high frequency loss. It's a little bit tricky since the hysteresis process doesn't have a constant group delay. For now I'll mark this issue as resolved, but feel free to re-open it if you have more questions/suggestions about this issue. This fix will be included in the next release (coming very soon :) ).

@darwindeez
Copy link
Author

darwindeez commented May 23, 2021 via email

@jatinchowdhury18
Copy link
Owner

Thanks, glad you're liking the hysteresis plugin! The current implementation is more of a "demo" implementation that was part of a research project I was working on, but it would be cool to turn it into a more fully-featured plugin. Most of my time at the moment is being spent working on a couple of other new plugins, but once I get those up and running this would be a cool project to work on next. I can let you know more as things progress!

@darwindeez
Copy link
Author

darwindeez commented May 25, 2021 via email

@jatinchowdhury18
Copy link
Owner

Ah interesting, thanks for sharing this context! While I doubt the Hysteresis plugin could sound exactly the same as VSM since it's not trying to model any analog hardware directly, that also means it could have the potential to be a more versatile digital effect. At the end of the day, I'm not really trying to have my plugins "compete" with anyone else's; as long as they are useful for musicians and engineers that's plenty good enough for me :).

@darwindeez
Copy link
Author

darwindeez commented Dec 26, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants