Skip to content
This repository has been archived by the owner on Jan 28, 2019. It is now read-only.

Set project to 0.1.0 #107

Merged
merged 14 commits into from
Mar 20, 2016
Merged

Set project to 0.1.0 #107

merged 14 commits into from
Mar 20, 2016

Conversation

arrdem
Copy link
Collaborator

@arrdem arrdem commented Mar 18, 2016

And fixup a bunch of metadata stuff for a release

@arrdem
Copy link
Collaborator Author

arrdem commented Mar 19, 2016

Apparently cljfmt hates my semantic comma style, so I guess I'll have to drop those hunks... another day.

@andrewhr
Copy link
Contributor

Reid, I've made a fix up commit to make cljfmt happy again, and another one that could be amended to Set :added one to remove a comment that becomes nonsensical in jaunt's context. The last one is about a Javadoc I've found after a search for version numbers on the codebase - you can drop it if you judge unnecessary.

I could do the rebase myself, but want to check with you before to avoid breaking any stuff on your side of the git branch magic.

One thing this PR still didn't address are those :deprecated meta which points to Clojure version numbers. Any Idea about how to deal with them?

@arrdem
Copy link
Collaborator Author

arrdem commented Mar 19, 2016

Okay.

  • Replaced all instances of ^{:deprecated String} with ^{:deprecated "0.1.0"} which is at least true. I'm not totally a fan of ^{:deprecated (Either Boolean String)} but given ^:deprecated I don't really see a way to avoid it.
  • Added changelog entry (all hail our unsleeping robot ci overlords).
  • Fixed one of your commit messages a tiny bit. (was "Fix ..." now "Fixup ...").

Thanks for catching the Javadoc stuff.

I guess I find the post-cljfmt "fixed" formatting to be worse than what it was before, but at least it's consistent. We can bring back the leading , thing if/when weavejester/cljfmt#67 gets closed.

Anything else that needs doing here?

@arrdem
Copy link
Collaborator Author

arrdem commented Mar 20, 2016

Looks like there are still a few references to 1.2 and 1.3 in the tests... do we care? I'm feelin not...

@andrewhr
Copy link
Contributor

I would say they do not. At least not as a big priority since they are all constrained to jaunt codebase

arrdem added a commit that referenced this pull request Mar 20, 2016
@arrdem arrdem merged commit 6239151 into develop Mar 20, 2016
@arrdem arrdem deleted the project/v0.1.0 branch March 20, 2016 00:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants