This repository has been archived by the owner on Jan 28, 2019. It is now read-only.
Implement Named over Namespaces #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arrdem
force-pushed
the
named-nss
branch
2 times, most recently
from
038c79f
to
6594cf9
Compare
Also mark ns-name as ^:deprecated since it is now replaced by name. BREAKING: Namespace.getName() previously existed, but returned a Symbol not a String. This method has been removed, and may cause problems down the line although the test suite is clean.
As of a4dba4a, Namespace returns a String not a Symbol, so the second .getName call isn't needed anymore and also doesn't resolve.
|
Tests died for no reason, kicked and we'll see if they're happy now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also mark ns-name as ^:deprecated since it is now replaced by name.