This repository has been archived by the owner on Jan 28, 2019. It is now read-only.
Promote ns-name from ^:deprecated #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecating ns-name was a mistake, since it serves a unique purpose with respect to name, being to fetch the naming _symbol_ rather than the naming _string_. Fixes #47
This patch avoids round tripping a symbol to a string and back by just getting the name field of the namespace.
arrdem
added a commit
that referenced
this pull request
Feb 1, 2016
Promote ns-name from ^:deprecated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47, see that issue for discussion of the reasons for rolling this
back. Rather than implementing the suggested
Namespace.getNamingSymbol():Symbol, this patch opts to use the existingfinal public Symbol namefield.