Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new errorprone warnings across java-json-tools #350

Open
Capstan opened this issue Sep 17, 2020 · 0 comments
Open

Fix new errorprone warnings across java-json-tools #350

Capstan opened this issue Sep 17, 2020 · 0 comments
Labels
dependencies Pull requests that update a dependency file feature

Comments

@Capstan
Copy link
Contributor

Capstan commented Sep 17, 2020

Spurred by #347 .

Since Google's monorepo has warnings-as-errors turned on, I did the same for the java-json-tools repos so that new errors requiring internal patching would be caught upstream before commit. However, the new https://github.com/dependabot suggestion of pulling in 2.4.0 finds new errorprone issues, which causes the builds to fail.

This is a FR to locally pull in 2.4.0, and commit fixes to the issues so the new error prone is clean.

/cc @huggsboson
@Capstan Capstan added feature dependencies Pull requests that update a dependency file labels Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Capstan