Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RegLoadAppKeyW #1377

Merged
merged 2 commits into from Aug 24, 2021
Merged

Conversation

@mfilippov
Copy link
Contributor

@mfilippov mfilippov commented Aug 23, 2021

Also, fix source compatibility with Java 6. It blocks my local test run.

Copy link
Member

@matthiasblaesing matthiasblaesing left a comment

Thank you - looks sane to me. I left an inline comment about the naming of the function and please remove the darwin-aarch64.jar.

And one additional request: Please add a feature entry for the newly bound function in CHANGES.md.

@mfilippov mfilippov force-pushed the mf-reg-open-app branch 3 times, most recently from b741bbb to 96965e7 Aug 23, 2021
@mfilippov
Copy link
Contributor Author

@mfilippov mfilippov commented Aug 23, 2021

@matthiasblaesing Do I need to add the registryLoadAppKey method in CHANGES.md or Advapi32.RegLoadAppKey is enough?

@matthiasblaesing
Copy link
Member

@matthiasblaesing matthiasblaesing commented Aug 23, 2021

I would mention both. If space is an issue the prefix com.sun.jna.platform. is commonly shorted to c.s.j.p..

@mfilippov
Copy link
Contributor Author

@mfilippov mfilippov commented Aug 23, 2021

@matthiasblaesing, it is ready.

@mfilippov mfilippov requested a review from matthiasblaesing Aug 23, 2021
Copy link
Member

@matthiasblaesing matthiasblaesing left a comment

Code change looks good. Last change request: Please rebase the changes onto current master. Sunday night the 5.9.0 release was cut. The git diff does not recognize the merge conflict, but it needs to be resolved (merging as is would add the change description to 5.9.0, but it will become part of 5.10.0).

@matthiasblaesing
Copy link
Member

@matthiasblaesing matthiasblaesing commented Aug 24, 2021

Sorry, the CHANGES.md is still wrong. The new change log entry is in the section for the released 5.9.0 version, but should be in the features subsection of the "Next Release (5.10.0)" section.

@mfilippov
Copy link
Contributor Author

@mfilippov mfilippov commented Aug 24, 2021

@matthiasblaesing I misunderstand it, sorry. I updated CHANGES.md

Copy link
Member

@matthiasblaesing matthiasblaesing left a comment

Looks good to me. Thank you.

@matthiasblaesing matthiasblaesing merged commit 030411b into java-native-access:master Aug 24, 2021
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants