Fixing Netapi32Util.getDomainTrusts() includes "empty" domain object #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add an entry to CHANGES under a new 3.5.1 section describing the fix, similar to the others. Also, maybe there's a way to extend the unit test to actually fail without this fix? Appreciated. |
…eclaration. This should fix the getDC method and unit test
|
The unit test was actually failing if you run it in a domain. |
|
So, since I not 100% familiar with git yet, I pushed another bugfix to my master branch, so I described both in CHANGES.md. I can do something different if you want - I'm just not sure how to do it. |
|
Very good, thank you. For next time just start with a branch so that you have a topic branch. It's a bit cleaner to keep master exactly in the state upstream is. |
dblock
added a commit
that referenced
this pull request
Oct 24, 2012
Fixing Netapi32Util.getDomainTrusts() includes "empty" domain object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After creating the DS_DOMAIN_TRUST structure from memory, read() was not being called to set the field values for the first array element from memory.
I'm adding a call to read() in the DS_DOMAIN_TRUST(Pointer p) constructor since this appears to be the convention.