Added basic Pdh API implementation #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,6 +47,7 @@ Features | |||
| * [#432](https://github.com/twall/jna/pull/432): Added SetLocalTime definition to 'com.sun.jna.platform.win32.Kernel32' - [@lgoldstein](https://github.com/lgoldstein). | |||
| * [#434](https://github.com/twall/jna/pull/434): Added GetEnvironmentStrings to 'com.sun.jna.platform.win32.Kernel32' - [@lgoldstein](https://github.com/lgoldstein). | |||
| * Loosen OSGI OS name matching to accommodate Windows 8 family - Niels Bertram. | |||
| * [#436] (https://github.com/twall/jna/pull/469): Added basic Pdh API implementation to `com.sun.jna.platform.win32' - [@lgoldstein](https://github.com/lgoldstein). | |||
There was a problem hiding this comment.
The second quote should also be a back quote, this doesn't render right.
There was a problem hiding this comment.
Done - will post an update pull request
|
This is nice and clean, great work! Fix the typo in CHANGELOG please via |
| public int HeaderLength; | ||
| public int NumObjectTypes; | ||
| public int DefaultObject; | ||
| public SYSTEMTIME SystemTime=new SYSTEMTIME(); |
There was a problem hiding this comment.
You might want to auto-format this file too, there should be a space around the =.
There was a problem hiding this comment.
Done - will post an updated pull request
|
FWIW performance counters are one of the best features of Windows and I have used it extensively. I encourage you to write up a blog post somewhere with an example of how to use this. |
|
Merging this, thanks. |
dblock
added a commit
that referenced
this pull request
Jul 20, 2015
Added basic Pdh API implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some (not all) of the API(s) in the pdh.dll - enough to enable using raw performance counters - as can be clearly demonstrated from the test.