-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Found and fixed duplicate method definitions for the same API #483
Found and fixed duplicate method definitions for the same API #483
Conversation
00e6184
to
403360d
Compare
There's a compile error in a contrib directory that looks legit:
|
403360d
to
bec85fd
Compare
Sorry I missed it - fixed and re-pushed the commit |
bec85fd
to
d256778
Compare
Took the opportunity to also remove the GetIconInfo overload with the HANDLE. |
d256778
to
d683e4f
Compare
Check out Travis-CI, didn't dig into the issues, but I am pretty sure this should be passing here. |
d683e4f
to
70288cc
Compare
You are right - I can't explain how, but seems like a bunch of critical import(s) was removed from the file. I restored them and now everything should compile - I don't know how this has happened since I compiled and tested my code before committing... |
All checks have passed successfully now |
Thanks, merging. Good work. |
Found and fixed duplicate method definitions for the same API
Kernel32:
User32:
Please note that the "changes" seem more than that but this is misleading - my IDE (Eclipse) is set up so that on "Save" it trims trailing white spaces in the source lines, replaces TAB(s) with 4 spaces, removes unused imports and adds missing @OverRide(s). I think this is recommended behavior, but do let me know if you disagree and I will configure it otherwise.