Added com port stuff #510
Merged
Added com port stuff #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great. Needs a CHANGELOG entry please. And squash your commits. |
|
Hi, added the missing CHANGELOG entries. |
| `boolean SetCommTimeouts(HANDLE hFile, WinBase.COMMTIMEOUTS lpCommTimeouts)`<br> | ||
| Added the following structure to com.sun.jna.platform.win32.WinBase:<br> | ||
| `DCB`<br> | ||
| [@MBollig](https://github.com/MBollig) |
There was a problem hiding this comment.
Sorry to be a pest, but can we please make these look like the other one-liners? Like
[#452](https://github.com/java-native-access/jna/pull/452): Added Mac OS X System.B library at `com.sun.jna.platform.mac.SystemB` including support for `sysctl`, `sysctlbyname`, `sysctlnametomib`, `mach_host_self`, `host_page_size`, `host_statistics` and `host_statistics64` - [@dbwiddis](https://github.com/dbwiddis).
|
Also please squash your commits. |
Had to remove a windows style new line to get the buid runnig with cywin Added com port stuff Added the follwing methods to com.sun.jna.platform.win32.Kernel32: boolean GetCommState(HANDLE hFile, WinBase.DCB lpDCB); boolean GetCommTimeouts(HANDLE hFile, WinBase.COMMTIMEOUTS lpCommTimeouts); boolean SetCommState(HANDLE hFile, WinBase.DCB lpDCB); boolean SetCommTimeouts(HANDLE hFile, WinBase.COMMTIMEOUTS lpCommTimeouts); Added the following structure to com.sun.jna.platform.win32.WinBase: DCB Added some new UnitTests Added new CHANGELOG entries. Fixed text Added com port stuff Added the follwing methods to com.sun.jna.platform.win32.Kernel32: boolean GetCommState(HANDLE hFile, WinBase.DCB lpDCB); boolean GetCommTimeouts(HANDLE hFile, WinBase.COMMTIMEOUTS lpCommTimeouts); boolean SetCommState(HANDLE hFile, WinBase.DCB lpDCB); boolean SetCommTimeouts(HANDLE hFile, WinBase.COMMTIMEOUTS lpCommTimeouts); Added the following structure to com.sun.jna.platform.win32.WinBase: DCB Added some new UnitTests
|
Hi, I fixed the changelog entry and squashed the commits.. |
|
Merged, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the follwing methods to com.sun.jna.platform.win32.Kernel32:
boolean GetCommState(HANDLE hFile, WinBase.DCB lpDCB);
boolean GetCommTimeouts(HANDLE hFile, WinBase.COMMTIMEOUTS lpCommTimeouts);
boolean SetCommState(HANDLE hFile, WinBase.DCB lpDCB);
boolean SetCommTimeouts(HANDLE hFile, WinBase.COMMTIMEOUTS lpCommTimeouts);
Added the following structure to com.sun.jna.platform.win32.WinBase:
DCB
Added some new UnitTests