Kernel32.ProcessIdToSessionId and resource extraction functions

[mlfreeman2]

Kernel32.dll Functions

• ProcessIdToSessionId
• LoadLibraryEx
• FindResource
• LoadResource
• LockResource
• SizeofResource
• FreeLibrary

The last 6 are implemented as a single workflow (utility function). It didn't make sense to submit them as individual PRs.
Given a file path, resource type, and resource name, the utility function in Kernel32Util should return a byte array of the resources's content.
ProcessIdToSessionId and LoadLibraryEx have their own tests, and the others are indirectly tested by testing the helper function.

[dblock]

What's up with all this HTML in the function descriptions. Looks like this was being cleaned up in other functions.

[mlfreeman2]

Yeah, I forgot this one.
Cleaned up now though.

[dblock]

You should squash your commits please. I'll let this sit here for other people's comments for a bit.

[mlfreeman2]

Ok, should be squashed now.

[dblock]

There're a lot of tab/spaces changes here, I think you have different defaults than what this project uses, so there're a bunch of non-changes. Would you mind taking a look please? Thx.

[mlfreeman2]

Sure, I can definitely reformat things.
Where are the official code format settings documented? Is there an Eclipse code formatter profile XML I can import?

Sent from my iPhone

On Nov 27, 2015, at 9:55 AM, Daniel Doubrovkine (dB.) @dblockdotorg notifications@github.com wrote:

There're a lot of tab/spaces changes here, I think you have different defaults than what this project uses, so there're a bunch of non-changes. Would you mind taking a look please? Thx.

—
Reply to this email directly or view it on GitHub.

[dblock]

@twall what's our tab/spaces story?

[twall]

Spaces only. Indent of 4. Look at the core JNA classes as an example, since the platform stuff is a bit less consistent.

On Nov 27, 2015, at 2:20 PM, Daniel Doubrovkine (dB.) @dblockdotorg notifications@github.com wrote:

@twall what's our tab/spaces story?

—
Reply to this email directly or view it on GitHub.

[mlfreeman2]

Ok, I've scrubbed the 5 Java files in this PR to match what @twall said.
Some of the whitespace changes that @dblock originally saw should stay - it appears that previous commits to these files were using tabs not spaces.

[dblock]

I'm merging this, thanks @mlfreeman2.