Apply generic definitions wherever applicable #577
Conversation
lgoldstein
force-pushed
the
apply-generics
branch
2 times, most recently
from
8e87337
to
8cc0a87
Compare
| @@ -6,18 +6,24 @@ | |||
|
|
|||
| public interface W32APIOptions extends StdCallLibrary { | |||
| /** Standard options to use the unicode version of a w32 API. */ | |||
| Map UNICODE_OPTIONS = Collections.unmodifiableMap(new HashMap() { | |||
| Map<Object, Object> UNICODE_OPTIONS = Collections.unmodifiableMap(new HashMap<Object, Object>() { | |||
There was a problem hiding this comment.
Options maps are always Map<String,Object>.
There was a problem hiding this comment.
You are right - don't know why I thought otherwise. Fixed and pushed updated files.
lgoldstein
force-pushed
the
apply-generics
branch
from
8cc0a87
to
0466f33
Compare
|
Strange failure since the core classes project (jna) succeeds, and it does reference Memory and Pointer, etc... |
|
I don't understand why it fails - I added (locally on my computer) an echo control message and the classpath seems in order:
The reference jna.jar exists and contains the Memory.class compiled code in it, so I don't understand why the compiler complains that it cannot find the symbol. I am at a loss as to why it fails to locate these symbols (and I have tried a lot of different things I know about ANT and JAVAC to no avail) - any help will be greatly appreciated... |
lgoldstein
force-pushed
the
apply-generics
branch
2 times, most recently
from
0b9c7a3
to
1ca2d4c
Compare
lgoldstein
force-pushed
the
apply-generics
branch
from
1ca2d4c
to
81908ed
Compare
|
Figured it out - trivial mistake - did not notice that I inadvertently removed some import(s) in the failing classes. Fixed and re-pushed - hopefully now everything will be OK... |
|
Seems that now everything is quiet - please review and see if OK to merge |
Apply generic definitions wherever applicable
Make the code at least 1.5 compatible so as to detect trivial errors during compile phas