Improve speed of GDIUtils.getScreenshot by ~30% #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good - I get similar measurements. Could you please add this as a feature to CHANGES.md? After that please squash the to commits and I'll merge that change to master. Thank you. |
|
Updated CHANGES.md, not at PC so I can't squash yet. Will do it tomorrow. |
|
When you have a look at it, please check the structure of the other CHANGE.md entries and follow that style. |
|
Fixed. Sorry, I thought the # were only issues, not PRs aswell. |
|
One final request: Could you please also add your username (see the other entries for the scheme). |
Instead of using setRGB on a newly created BufferedImage, create a raster from the pixel buffer and create the BufferedImage from that. This is the same way that java.awt.Robot does it.
|
Merged - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using setRGB on a newly created BufferedImage, create a from the pixel buffer and create the BufferedImage from that.
This is the same way that java.awt.Robot does it.