New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependent project can't find module-info #125
Comments
Thanks for your detailed bug report, Andres! The issue you report is similar to #107. I hoped I fixed it with #109, but apparently, I haven't (at least not entirely). I cloned ikonli and tried to build it from Lines 25 to 29 in e01508d
I got the following dependencies on
and the following dependencies on other tasks:
Unfortunately, many subprojects (incl. As a workaround, I wanted to suggest adding the following lines to if (subproj.name.endsWith('-pack')) {
subproj.compileModuleInfoJava.dependsOn project(':ikonli-core').compileModuleInfoJava
} However, for a reason that escapes me, it still doesn't help (although, to the best of my knowledge, it should). In other words, Gradle still tries to execute After some more digging, I discovered something interesting. When I tried to clean the build, and then run
Interestingly, To sum up, it's certainly a bug in this plugin, and it seems related to #99, where this
Hope it helps (however far from perfect this is, but I'm afraid I won't find resources in any foreseeable future to try and fix this bug). |
Thanks for the suggestion @tlinkowski. The following snippet allows projects to compile
However the generated JAR files are wrong as they include duplicate entries
I'm afraid this may be related to the |
Eh, something is really broken in this plugin 😕 E.g. as far as I remember, So I bet the current problem with the JAR occurs because both |
Any news? |
Encountered this particular problem when attempting to solve controlsfx/controlsfx#1195 (comment)
The Ikonli project currently provides Java11 only support in its artifacts. All artifacts have a corresponding
module-info.java
file. Addingmodularity.MixedRelease = 8
to certain projects causes the build to fail withThe
multi-release
branch contains the failing setup. Please see https://github.com/aalmiray/ikonli/blob/multi-release/build.gradleThe
compileJavaSettings
task from the Kordamp Plugin Suite shows the following settings for:ikonli-dashicons-pack:compileJava
Here we can appreciate that the classpath includes a reference to
ikonli-core
where theorg.kordamp.ikonli.core
module is located. Inspecting the settings for:ikonli-dashicons-pack:compileModuleInfoJava
yields the followingBTW you can get all settings by invoking
Notice that
:ikonli-dashicons-pack:compileModuleInfoJava
knows nothing of the output fromikonli-core:compileModuleInfoJava
which contains the compiled module information. Perhaps this is the cause of the problem?The text was updated successfully, but these errors were encountered: