Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line arguments for JavaCC 4 and JavaCC 8 #60

Merged
merged 4 commits into from
Jul 16, 2023

Conversation

zbynek
Copy link
Collaborator

@zbynek zbynek commented Dec 30, 2022

Fixes #50

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022

Codecov Report

Patch coverage: 40.00% and project coverage change: -1.67 ⚠️

Comparison is base (6ca01dc) 87.73% compared to head (f5b02dc) 86.06%.

❗ Current head f5b02dc differs from pull request most recent head deb38d9. Consider uploading reports for the commit deb38d9 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #60      +/-   ##
============================================
- Coverage     87.73%   86.06%   -1.67%     
- Complexity      149      150       +1     
============================================
  Files            23       23              
  Lines           432      445      +13     
  Branches         28       33       +5     
============================================
+ Hits            379      383       +4     
- Misses           49       58       +9     
  Partials          4        4              
Impacted Files Coverage Δ
.../javacc/programexecution/JjtreeProgramInvoker.java 55.00% <40.00%> (-45.00%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zbynek zbynek changed the title Workaround for JavaCC 4 bug Add command line arguments for JavaCC 4 and JavaCC 8 Jul 16, 2023
@zbynek zbynek merged commit fb28795 into javacc:master Jul 16, 2023
1 check passed
@zbynek zbynek deleted the javacc-4 branch July 16, 2023 19:25
@zbynek zbynek mentioned this pull request Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does this plugin support javacc 4.0v?
2 participants