Skip to content
This repository has been archived by the owner on Apr 25, 2019. It is now read-only.

Moved all data from data/ into inst/extdata and updated references #13

Merged
merged 1 commit into from
Aug 17, 2015

Conversation

ClaytonJY
Copy link
Contributor

@javadch, please run R CMD check and execute examples from Examples/ directory and let me know if this new schema works.

At least one example should have never worked before: RQtTest2.R has a variable cnnString which was using Data instead of data.

I'm particularly curious about weatherR.R; that's the only place we read data directly into R, so I changed it to use system.file() as suggested by Hadley here.

This should fix #4, #7, and #10.

javadch added a commit that referenced this pull request Aug 17, 2015
Moved all data from data/ into inst/extdata and updated references
@javadch javadch merged commit ada4735 into develop Aug 17, 2015
@javadch
Copy link
Owner

javadch commented Aug 17, 2015

I fixed a small issue with relative paths on the devlop branch. but it does not solve this issue. When I run R CMD check, 1: "Examples" folder is not copied to the RQt.Rcheck folder. 2: it is expected to be in the root folder not in the RQt.Rcheck\RQt etc. see SHA: a925324

@ClaytonJY
Copy link
Contributor Author

@javadch, we can not rely on ANYTHING being copied to the root of RQt.Rcheck/; any such requirement should be considered a bug. To get this thing on CRAN we need to be able to pass R CMD check in one pass, without the --no-clean option we're currently building with.

@javadch
Copy link
Owner

javadch commented Aug 17, 2015

Is there a way, inside a function, to know whether the function is called from CHECK mode or INSTALL mode. If possible maybe I can pass some parameters to the getEngine function to tell it where to expect the config in either mode.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants