now can sandbox on JVMs that do not support ThreadMXBean #84
+25
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In some cases JVMs may not support thead allocated memory measurement. This check is performed when calling It was throwing an If the user does not configure a max cpu time or max memory usage, this fact can be ignored. However if the user sets either a CPU limit or memory limit, then this exception is valid and must not be caught and swallowed. |
amoravec
commented
Apr 9, 2019
|
|
||
| private final com.sun.management.ThreadMXBean memoryCouter; |
There was a problem hiding this comment.
Fixed typo memoryCouter -> memoryCounter
|
That looks very useful, thank you! Going to package up a new version with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#83