This repository has been archived by the owner on Oct 25, 2018. It is now read-only.
Seeking Review: Documentation of the feature. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 1, 2017 14:44
modified: README.md modified: api/src/main/java/org/glassfish/grizzly/npn/AlpnClientNegotiator.java modified: api/src/main/java/org/glassfish/grizzly/npn/AlpnServerNegotiator.java
rlubke
reviewed
Nov 3, 2017
README.md
Outdated
|
|
||
| --- | ||
|
|
||
| ## How to Avoid IP Taint When Examining this Code |
README.md
Outdated
| [`Http2AddOn`](https://github.com/javaee/grizzly/blob/e0e9200479851078d9cf2bad1cf29fa72f525437/modules/http2/src/main/java/org/glassfish/grizzly/http2/Http2AddOn.java) | ||
| This `AddOn` implementation inserts some filters in the chain in the | ||
| proper order to ensure that ALPN concerns are handled first, and then | ||
| the HTTP/2 protocol is handled. The former is of interest here. |
There was a problem hiding this comment.
Better phrased as something like: in addition to registering filters for HTTP/2 processing, it registers a callback with the ALPN extension.
README.md
Outdated
|
|
||
| By the time `onStart` is invoked, the handshake listener will have | ||
| been initialized with implementations of `AlpnClientNegotiator` and | ||
| `AlpnServerNegotiator`. |
README.md
Outdated
| The above programmatic configuration steps will make it so the simple | ||
| act of including the module built from the `bootstrap` sub-module of | ||
| this repository in the "endorsed" directory of the JVM will enable ALPN | ||
| support in that JVM. |
There was a problem hiding this comment.
I would recommend documenting the use of bootclasspath vs endorsed of the JVM so as to not impact all applications that are using the JVM, only those that need ALPN.
|
@rlubke Please review and accept this PR if you agree. Once you do, I'll point the customer to it. Thanks, Ed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.