Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

JDK-8207377 Document behavior of getPixelColor on HiDPI. #140

Merged
merged 2 commits into from Jul 24, 2018

Conversation

brcolow
Copy link
Contributor

@brcolow brcolow commented Jul 21, 2018

@kevinrushforth kevinrushforth self-requested a review July 24, 2018 17:54
@@ -251,7 +251,12 @@ public Color getPixelColor(double x, double y) {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good. There are two getPixelColor methods in Robot.java. Can you also update the docs for the other one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew I forgot something, lol.

Copy link
Collaborator

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kevinrushforth kevinrushforth merged commit c62dab4 into javafxports:develop Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants