Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

JDK-8209966: Update minimum boot JDK to 11 #174

Merged
merged 1 commit into from Sep 25, 2018
Merged

JDK-8209966: Update minimum boot JDK to 11 #174

merged 1 commit into from Sep 25, 2018

Conversation

kevinrushforth
Copy link
Collaborator

Fix for JBS issue JDK-8209966.

Bump the minimum JDK version needed to build JavaFX to jdk-11+28.

Note that this will not change the javac --source or --target flags (which are controlled in build.gradle by the 'sourceCompatibility' option), which will remain at 10.

This will allow us to implement the following follow-on issues:

  1. Compile with --source 11 --target 11
  2. Stop building the old javafx.swing implementation which relies on internal API (using qualified exports on the command line)
  3. Stop redistributing the Microsoft VS2017 and Windows SDK DLLs (since they are present in JDK 11).

@kevinrushforth kevinrushforth added enhancement New feature or request WIP Work In Progress labels Aug 27, 2018
@kevinrushforth kevinrushforth self-assigned this Aug 27, 2018
@kevinrushforth
Copy link
Collaborator Author

NOTE: this is not yet ready to merge, since we want to wait until JDK 11 has released its final (GA) build before requiring it for building FX.

@kevinrushforth kevinrushforth changed the title [WIP] JDK-8209966: Update minimum boot JDK to 11 JDK-8209966: Update minimum boot JDK to 11 Sep 21, 2018
@kevinrushforth kevinrushforth removed the WIP Work In Progress label Sep 21, 2018
@kevinrushforth
Copy link
Collaborator Author

This is now ready for review.

Pending the review, this will only be merged after JDK 11 is released, which is scheduled for Tuesday, 2018-09-25.

@kevinrushforth
Copy link
Collaborator Author

@tiainen this might require you to update your build machine with the latest JDK 11, since EA builds of JDK 11 will be below the minimum.

Copy link
Collaborator

@johanvos johanvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this will work with the changes in e7da3eb (which should then retrieve a jdk with at least buildnum 28)

@kevinrushforth
Copy link
Collaborator Author

kevinrushforth commented Sep 22, 2018

Yes, the fix for issue #159, e7da3eb, will cause the AppVeyor and Travis builds to grab the latest build of JDK 11, which is jdk-11+28.

@tiainen
Copy link
Contributor

tiainen commented Sep 24, 2018

Thanks for the heads up. We'll update the JDK on our build machines to the released JDK 11.

@kevinrushforth
Copy link
Collaborator Author

Note: I updated the date of the commit, and pushed it, to trigger a CI test build, but the content itself is unchanged from the previous version.

@kevinrushforth kevinrushforth merged commit f250fbf into javafxports:develop Sep 25, 2018
@kevinrushforth kevinrushforth deleted the JDK-8209966-jdk-11 branch September 25, 2018 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants