Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider with-prefix #2

Closed
odrotbohm opened this issue Feb 5, 2020 · 3 comments
Closed

Reconsider with-prefix #2

odrotbohm opened this issue Feb 5, 2020 · 3 comments
Assignees
@javahippie
Labels
enhancement New feature or request

Comments

@odrotbohm
Copy link

By convention, wither methods usually return fresh instances of the object type the method is called on. Is there a particular reason you're not simply using propertyName(…) as methods on the builder? That would nicely align with the naming convention of records, too.
@javahippie
Copy link
Owner

javahippie commented Feb 5, 2020 •
edited

Thanks for the suggestion! It matches suggestions already made on Twitter, and will be addressed in the next days.

@javahippie javahippie added the enhancement New feature or request label Feb 5, 2020
@javahippie javahippie self-assigned this Feb 5, 2020
@odrotbohm
Copy link
Author

Awesome, Tim, thanks!

javahippie pushed a commit that referenced this issue Feb 5, 2020
#2 - Modify builder syntax after multiple recommendations
46bb652
javahippie pushed a commit that referenced this issue Feb 5, 2020
#2 - Remove 'with' prefix, as recommended by several people
1a977e8
@javahippie
Copy link
Owner

Solved with release 0.2

@javahippie javahippie mentioned this issue Feb 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javahippie javahippie

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@odrotbohm @javahippie