Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticking checkboxes doesn't work #9

Closed
0x4c46 opened this issue Apr 18, 2021 · 7 comments
Closed

Ticking checkboxes doesn't work #9

0x4c46 opened this issue Apr 18, 2021 · 7 comments

Comments

@0x4c46
Copy link

0x4c46 commented Apr 18, 2021

Very cool plugin to upgrade files visually! Thank you. Unfortunately it's not possible to tick checkboxes inside admonition enviroment in preview.

@valentine195
Copy link
Member

Okay, this should work now.

Unfortunately Obsidian's MarkdownRenderer doesn't appear to handle this situation if it is not rendering the entire page, so I had to hack it in. This may not work completely the same as native checkboxes.

@0x4c46
Copy link
Author

0x4c46 commented Apr 19, 2021

Thanks, but after this update only the first checkbox of Admonition blocks can be ticked.

@valentine195
Copy link
Member

Okay, I see why. Let me work on it, should have a fix soon.

@valentine195 valentine195 reopened this Apr 19, 2021
valentine195 added a commit that referenced this issue Apr 19, 2021
- Fixed issue related to multiple checkboxes in admonitions (#9)
@valentine195
Copy link
Member

Can you verify if 3.1.2 fixes it?

@0x4c46
Copy link
Author

0x4c46 commented Apr 19, 2021

Yes, it did fix it. Thank you very much for your fast support.

@valentine195
Copy link
Member

Great, thank you. Let me know if you run into other issues -- like I said, I had to hack in a way to force Obsidian to do this, and it may be a little wonky on edge cases.

@0x4c46
Copy link
Author

0x4c46 commented Aug 23, 2021

Hi Valentine, it's broken again but I don't know since which release.
Thank you for fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants