Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Android Docs #211

Closed
zugazagoitia opened this issue Feb 14, 2023 · 4 comments · Fixed by #212
Closed

Update Android Docs #211

zugazagoitia opened this issue Feb 14, 2023 · 4 comments · Fixed by #212

Comments

@zugazagoitia
Copy link
Member

The SDK versions in the documentation might/should not work with Javalin 5/Jetty 11.
See: javalin/javalin#1821
@tipsy
Copy link
Member

tipsy commented Feb 14, 2023

Will never versions work, or are we out of luck for Jetty 11 ?

@zugazagoitia
Copy link
Member Author

The user who reported the issue got it working with sdk33 (Android 13) I will try to execute javalin testsuite to check if everything works

@zugazagoitia
Copy link
Member Author

First off we should change

2: Target Java 8:

compileOptions {
    sourceCompatibility JavaVersion.VERSION_1_8
    targetCompatibility JavaVersion.VERSION_1_8
}

to Java 11

@zugazagoitia
Copy link
Member Author

zugazagoitia commented Feb 21, 2023 •
edited

After some research and several attempts to run Javalin 5 in Android (SDK33 and Android 13, JDK11), I believe it is impossible.

The ServiceLoader class in the android SDK is missing the Provider interface used by Jetty.

I'll update the docs accordingly.

zugazagoitia added a commit to zugazagoitia/javalin.github.io that referenced this issue Feb 21, 2023
@zugazagoitia
Update Android Docs
119d8f2 
Closes javalin#211
@zugazagoitia zugazagoitia mentioned this issue Feb 21, 2023
Merged
zugazagoitia added a commit to zugazagoitia/javalin.github.io that referenced this issue Feb 22, 2023
@zugazagoitia
Update Android Docs
51c52d3 
Fixes javalin#211
tipsy pushed a commit that referenced this issue Feb 22, 2023
@zugazagoitia
Update Android Docs (#212)
44f76ee 
* Update Android Docs
Closes #211

* Update docs.md

* Update Android Docs
Fixes #211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Android Docs zugazagoitia/javalin.github.io
2 participants
@tipsy @zugazagoitia