New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended OpenApiPlugin, to support multiple options #1117
Conversation
Nice, thank you @sauterl ! Could you fix the indentation changes? |
Thanks for the quick reply @tipsy My apologies, the indentation should be fixed by now. If there are any questions / changes to be made, please let me know. |
Looks fine to me. I believe there's another issue for this that was submitte some time ago. Let me see if I can find it. |
javalin-openapi/src/test/kotlin/io/javalin/examples/HelloWorldMultiSwagger.kt
Outdated
Show resolved
Hide resolved
…MultiSwagger.kt Co-authored-by: David <davidaase@hotmail.com>
Thanks @tipsy for finding the other issue, I have to admit that, due to the terminology of swagger docs and OpenApi Specifications (and everything in between), I did not see the #893 . However, as far as I can tell this would fix their issue as well.
Thanks again for the quick replies |
You're very welcome, thank you too for your quick PR :) |
This is a small addition to the
OpenApiPlugin
, enabling devs to have multiple concurrent OpenApi specifications, as originally in #1108The addition has a rather simple approach: If
OpenApiOptions
differ in their path, they are added to be served concurrently, so now theOpenApiPlugin
constructor accepts a variable amount of options: