[testing] ContextMock (#1976)
#2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…linServlet implementation
# Conflicts: # javalin/src/main/java/io/javalin/config/PrivateConfig.kt # javalin/src/main/java/io/javalin/http/servlet/DefaultTasks.kt
# Conflicts: # javalin/src/main/java/io/javalin/config/PrivateConfig.kt # javalin/src/main/java/io/javalin/plugin/bundled/HttpAllowedMethodsPlugin.kt
|
Classic Maven incident and its inability to get the root directory for multimodule project 😔 I'll play with it tomorrow. |
# Conflicts: # javalin/src/main/java/io/javalin/config/PrivateConfig.kt
# Conflicts: # javalin/src/main/java/io/javalin/http/servlet/JavalinServlet.kt # javalin/src/main/java/io/javalin/http/servlet/JavalinServletContext.kt
|
I'll try to have a proper look at this in the weekend! |
# Conflicts: # javalin/src/main/java/io/javalin/plugin/bundled/DevLoggerPlugin.kt
tipsy
approved these changes
Dec 4, 2023
javalin-utils/javalin-context-mock/src/main/java/io/javalin/mock/ContextMock.kt
Outdated
Show resolved
Hide resolved
javalin-utils/javalin-context-mock/src/main/java/io/javalin/mock/ContextMockConfig.kt
Show resolved
Hide resolved
javalin-utils/javalin-context-mock/src/main/java/io/javalin/mock/ContextMockConfigurer.kt
Outdated
Show resolved
Hide resolved
...ils/javalin-context-mock/src/main/java/io/javalin/mock/servlet/InMemoryHttpServletRequest.kt
Show resolved
Hide resolved
...ls/javalin-context-mock/src/main/java/io/javalin/mock/servlet/InMemoryHttpServletResponse.kt
Show resolved
Hide resolved
…ck/ContextMock.kt Co-authored-by: David (javalin.io) <davidaase@hotmail.com>
…invokeConfigWithConfigurerScope
|
Probably done, I mean... it's not a real req/res impl so there are definitely some differences, but I guess we can fix this on user request. The foundation seems to work quite fine :) |
|
Thank you for all your effort @dzikoysk, let's make sure we promote this to get some user feedback 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on (& blocked by) branch from 1st PR:
Endpointin public API #2013I don't quite like
xxx-utilslibraries, because it's usually a garbage can for random things and no one knows what's actually there.I took a different approach and made
javalin-utilsa parent pom, wherejavalin-context-mockis its first child module. Thanks to that, we can still encapsulate utility features within the-utilsscope in the repository, but it's effectively still granulated & independent functionality.I think it might be even a good idea to pull
javalin-utils/javalin-testtoolshere, maybe with a more precise name likejavalin-okhttp-testtool/javalin-okhttp-tester(?)