Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uses for SLF4J #2137

Merged
merged 2 commits into from Feb 24, 2024
Merged

Add uses for SLF4J #2137

merged 2 commits into from Feb 24, 2024

Conversation

SentryMan
Copy link
Contributor

fixes #2136

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.31%. Comparing base (7da42d0) to head (53dfa26).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2137   +/-   ##
=========================================
  Coverage     86.31%   86.31%           
  Complexity     1297     1297           
=========================================
  Files           148      148           
  Lines          4042     4042           
  Branches        506      506           
=========================================
  Hits           3489     3489           
  Misses          334      334           
  Partials        219      219           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tipsy tipsy merged commit e0d8c27 into javalin:master Feb 24, 2024
15 checks passed
@tipsy
Copy link
Member

tipsy commented Feb 24, 2024

Thanks @SentryMan !

@tipsy
Copy link
Member

tipsy commented Feb 24, 2024

@SentryMan is there some way to test for this? I accidentally removed the dependency when I was removing a unused service loader for templating.

@SentryMan
Copy link
Contributor Author

SentryMan commented Feb 24, 2024

could make another test module and run those on the module path instead of the class path

@tipsy
Copy link
Member

tipsy commented Feb 24, 2024

Could you submit a PR for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Javalin fails on JPMS with module io.javalin does not declare uses
2 participants