Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[websocket] Add roles and path params to weBeforeUpgrade #2173

Merged
merged 1 commit into from Mar 2, 2024

Conversation

tipsy
Copy link
Member

@tipsy tipsy commented Mar 1, 2024

No description provided.

@tipsy tipsy marked this pull request as ready for review March 1, 2024 22:55
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.32%. Comparing base (4cd995a) to head (e29e161).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2173   +/-   ##
=========================================
  Coverage     86.31%   86.32%           
- Complexity     1297     1298    +1     
=========================================
  Files           148      148           
  Lines          4042     4044    +2     
  Branches        506      507    +1     
=========================================
+ Hits           3489     3491    +2     
  Misses          334      334           
  Partials        219      219           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Playacem Playacem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tipsy tipsy merged commit 2591fdf into master Mar 2, 2024
28 checks passed
@tipsy tipsy deleted the websocket-fix branch March 2, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants