Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveJDBC-KT module is not generating JavaDoc #1093

Closed
ipolevoy opened this issue Apr 6, 2021 · 7 comments
Closed

ActiveJDBC-KT module is not generating JavaDoc #1093

ipolevoy opened this issue Apr 6, 2021 · 7 comments
Assignees

Comments

@ipolevoy
Copy link
Member

ipolevoy commented Apr 6, 2021

I tried to push a release through Sonatype today, and it was rejected because the KT module had no javadoc.jar file.

It might be related to: #874

The new release was on the java11 branch for OpenJDK 11.

When I simply tried this:

activejdbc-kt>   mvn javadoc:javadoc

nothing useful was generated.

@davy-claisse, can you take a look, please? We need to push the Java11 release out.

Selection_999(733)

@ipolevoy ipolevoy changed the title ActiveJDBC -KT module is not generating JavaDoc ActiveJDBC-KT module is not generating JavaDoc Apr 6, 2021
@davy-claisse
Copy link
Contributor

@ipolevoy Apparently Jetbrains published on Maven Central an 1.4.30 version of Dokka that seems to fix the previous Java 11 compliance problem.

Just let me have look on this, I'll check that.

@ipolevoy
Copy link
Member Author

ipolevoy commented Apr 6, 2021

@davy-claisse yes, I saw that. Thanks for looking!

@davy-claisse
Copy link
Contributor

@ipolevoy I found a way to produce a JAR of JavaDoc for Kotlin classes using Dokka but to do that I added the generation of Kotlin Doc during the Maven's phase package. If it's not convenient for you, please feel free to change it for the phase you prefer.

Note: I synchronized the version used by the Kotlin compiler to the one used by Dokka, this means activejdbc-kt will now be based on Kotlin 1.4 instead of Kotlin 1.3 (no regressions found during by unit tests).

I'll submit the PR in few minutes.

davy-claisse added a commit to davy-claisse/activejdbc that referenced this issue Apr 6, 2021
…1 platform

- The module ActiveJDBC-KT uses now Kotlin 1.4 for everything (KDoc + Compiler).
- The KDoc (aka JavaDoc for Kotlin) is generated during the Maven's phase
  `package` to be sure the Jar of JavaDoc will be present before the SonarQube
  analysis.
@ipolevoy
Copy link
Member Author

ipolevoy commented Apr 6, 2021

@ipolevoy I found a way to produce a JAR of JavaDoc for Kotlin classes using Dokka but to do that I added the generation of Kotlin Doc during the Maven's phase package. If it's not convenient for you, please feel free to change it for the phase you prefer.

@davy-claisse appreciate a lightning -fast turnaround! This is not my convenience though. Once the PR is in, I will try to submit a new release to Sonatype. Let's keep the fingers crossed that they will accept it.

ipolevoy pushed a commit that referenced this issue Apr 19, 2021
- The module ActiveJDBC-KT uses now Kotlin 1.4 for everything (KDoc + Compiler).
- The KDoc (aka JavaDoc for Kotlin) is generated during the Maven's phase
  `package` to be sure the Jar of JavaDoc will be present before the SonarQube
  analysis.
@ipolevoy
Copy link
Member Author

@davy-claisse I released the version 3.0-j11 for java 11, so your fix worked.

Unfortunately, I tried to release ve 3.0 for Java 15, and got the same exact issue. I cherry-picked your commit to the master branch beforehand. Somehow this is not working on Java 15. Any idea?

@ipolevoy
Copy link
Member Author

ipolevoy commented Apr 20, 2021

@davy-claisse , sorry have you had a chance to look into it? It is delaying a release of 3.0 for Java 15.

@ipolevoy
Copy link
Member Author

I think I made a mistake. It is working on java 15, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants