New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActiveJDBC-KT module is not generating JavaDoc #1093
Comments
@ipolevoy Apparently Jetbrains published on Maven Central an 1.4.30 version of Dokka that seems to fix the previous Java 11 compliance problem. Just let me have look on this, I'll check that. |
@davy-claisse yes, I saw that. Thanks for looking! |
@ipolevoy I found a way to produce a JAR of JavaDoc for Kotlin classes using Dokka but to do that I added the generation of Kotlin Doc during the Maven's phase Note: I synchronized the version used by the Kotlin compiler to the one used by Dokka, this means activejdbc-kt will now be based on Kotlin 1.4 instead of Kotlin 1.3 (no regressions found during by unit tests). I'll submit the PR in few minutes. |
…1 platform - The module ActiveJDBC-KT uses now Kotlin 1.4 for everything (KDoc + Compiler). - The KDoc (aka JavaDoc for Kotlin) is generated during the Maven's phase `package` to be sure the Jar of JavaDoc will be present before the SonarQube analysis.
@davy-claisse appreciate a lightning -fast turnaround! This is not my convenience though. Once the PR is in, I will try to submit a new release to Sonatype. Let's keep the fingers crossed that they will accept it. |
- The module ActiveJDBC-KT uses now Kotlin 1.4 for everything (KDoc + Compiler). - The KDoc (aka JavaDoc for Kotlin) is generated during the Maven's phase `package` to be sure the Jar of JavaDoc will be present before the SonarQube analysis.
@davy-claisse I released the version 3.0-j11 for java 11, so your fix worked. Unfortunately, I tried to release ve 3.0 for Java 15, and got the same exact issue. I cherry-picked your commit to the master branch beforehand. Somehow this is not working on Java 15. Any idea? |
@davy-claisse , sorry have you had a chance to look into it? It is delaying a release of 3.0 for Java 15. |
I think I made a mistake. It is working on java 15, closing. |
I tried to push a release through Sonatype today, and it was rejected because the KT module had no javadoc.jar file.
It might be related to: #874
The new release was on the java11 branch for OpenJDK 11.
When I simply tried this:
nothing useful was generated.
@davy-claisse, can you take a look, please? We need to push the Java11 release out.
The text was updated successfully, but these errors were encountered: