Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log4j implementation is included in the common module #1118

Closed
ipolevoy opened this issue May 21, 2021 · 1 comment
Closed

Log4j implementation is included in the common module #1118

ipolevoy opened this issue May 21, 2021 · 1 comment
Assignees
@ipolevoy
Labels
enhancement Module: Other

Comments

@ipolevoy
Copy link
Member

and this is not the best, since if you need another implementation, you have to exclude this one

javalite/javalite-common/pom.xml

Line 95 in 3e2c35d

<artifactId>log4j-slf4j-impl</artifactId>

@ipolevoy ipolevoy self-assigned this May 21, 2021
@ipolevoy
Copy link
Member Author

it also messes logging from downstream modules that want to log to STDIO - look out for those SLF4J warnings on the console

@ipolevoy ipolevoy mentioned this issue Nov 22, 2021
Closed
ipolevoy added a commit that referenced this issue Nov 22, 2021
@ipolevoy
#1118 - Log4j implementation is included in the common module
1226b1d
ipolevoy added a commit that referenced this issue Nov 22, 2021
@ipolevoy
#1118 - Log4j implementation is included in the common module
7b134b3 
(cherry picked from commit 1226b1d)
ipolevoy added a commit that referenced this issue Jan 1, 2023
@ipolevoy
#1118 - Log4j implementation is included in the common module
142dede 
commenting out integration tests because the testing infrastructure has changed, and it would be too much hassle to make changes for this version.

(cherry picked from commit 1226b1d)
ipolevoy added a commit that referenced this issue Jan 1, 2023
@ipolevoy
#1118 - Log4j implementation is included in the common module
4d5373b 
(cherry picked from commit 1226b1d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ipolevoy ipolevoy

Labels
enhancement Module: Other
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ipolevoy