ClassLoader cannot load model classes under OpenJDK 11. Is Java 11 even supported? #803

lpld · 2018-10-24T17:51:41Z

Trying to migrate our apps to Java 11. Got an error while starting the app, definitely something related to instrumentation. Using latest available version of ActiveJDBC (2.2). Error happens under AdoptOpenJDK jdk-11.28.
I couldn't find any info about the supported Java versions in ActiveJDBC. Is Java 11 supported?
Here's the log:

java.lang.ClassFormatError: Nest member class_info_index 10 has bad constant type in class file com/company/model/MyModelClass
        at java.base/java.lang.ClassLoader.defineClass1(Native Method)
        at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1016)
        at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174)
        at org.apache.catalina.loader.WebappClassLoaderBase.findClassInternal(WebappClassLoaderBase.java:2337)
        at org.apache.catalina.loader.WebappClassLoaderBase.findClass(WebappClassLoaderBase.java:829)
        at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1278)
        at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1137)
        at java.base/java.lang.Class.getDeclaredMethods0(Native Method)
        at java.base/java.lang.Class.privateGetDeclaredMethods(Class.java:3167)
        at java.base/java.lang.Class.getDeclaredMethods(Class.java:2310)
        at org.glassfish.jersey.server.model.IntrospectionModeller$2.run(IntrospectionModeller.java:255)
        at java.base/java.security.AccessController.doPrivileged(Native Method)
        at org.glassfish.jersey.server.model.IntrospectionModeller.getAllDeclaredMethods(IntrospectionModeller.java:249)
        at org.glassfish.jersey.server.model.IntrospectionModeller.checkForNonPublicMethodIssues(IntrospectionModeller.java:174)
        at org.glassfish.jersey.server.model.IntrospectionModeller.doCreateResourceBuilder(IntrospectionModeller.java:121)
        at org.glassfish.jersey.server.model.IntrospectionModeller.access$000(IntrospectionModeller.java:82)
        at org.glassfish.jersey.server.model.IntrospectionModeller$1.call(IntrospectionModeller.java:114)
        at org.glassfish.jersey.server.model.IntrospectionModeller$1.call(IntrospectionModeller.java:111)
        at org.glassfish.jersey.internal.Errors.process(Errors.java:316)
        at org.glassfish.jersey.internal.Errors.process(Errors.java:298)
        at org.glassfish.jersey.internal.Errors.processWithException(Errors.java:256)
        at org.glassfish.jersey.server.model.IntrospectionModeller.createResourceBuilder(IntrospectionModeller.java:111)
        at org.glassfish.jersey.server.model.Resource.from(Resource.java:800)
        at org.glassfish.jersey.server.ResourceBagConfigurator.init(ResourceBagConfigurator.java:79)
        at org.glassfish.jersey.server.ApplicationHandler.initialize(ApplicationHandler.java:354)
        at org.glassfish.jersey.server.ApplicationHandler.lambda$initialize$1(ApplicationHandler.java:316)
        at org.glassfish.jersey.internal.Errors.process(Errors.java:316)
        at org.glassfish.jersey.internal.Errors.process(Errors.java:298)
        at org.glassfish.jersey.internal.Errors.processWithException(Errors.java:256)
        at org.glassfish.jersey.server.ApplicationHandler.initialize(ApplicationHandler.java:315)
        at org.glassfish.jersey.server.ApplicationHandler.<init>(ApplicationHandler.java:282)
        at org.glassfish.jersey.servlet.WebComponent.<init>(WebComponent.java:335)
        at org.glassfish.jersey.servlet.ServletContainer.init(ServletContainer.java:178)
        at org.glassfish.jersey.servlet.ServletContainer.init(ServletContainer.java:370)
        at javax.servlet.GenericServlet.init(GenericServlet.java:158)
        at org.apache.catalina.core.StandardWrapper.initServlet(StandardWrapper.java:1144)
        at org.apache.catalina.core.StandardWrapper.load(StandardWrapper.java:986)
        at org.apache.catalina.core.StandardContext.loadOnStartup(StandardContext.java:4978)
        at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5290)
        at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
        at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1420)
        at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1410)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:834)

Thank you.

The text was updated successfully, but these errors were encountered:

ipolevoy · 2018-10-24T18:29:38Z

Sorry, but we are not supporting JDK above 8.x yet

lpld · 2018-10-24T18:33:46Z

Any plans to support them in the near future?

ipolevoy · 2018-10-24T18:36:00Z

@lpld good question, I do not see reasons why not, also considering the current state of Java, we should migrate to OpenJDK and probably skip versions 9, 10 and start supporting v 11.
But before that, we probably need to make the last release for v8

thoughts?

lpld · 2018-10-24T19:03:44Z

Well, I like the plan :) Supporting 9 and 10 definitely wouldn't make any sense.

BTW, is there any way I can help? I won't be able to spend too much time, but I think I could find some.

ipolevoy · 2018-10-24T19:17:03Z

@lpld that would be great! Can you fork, and run the build on OpenJDK 9 first? Then v 11.

Some work for JDK9 has already been done on this branch: https://github.com/javalite/activejdbc/commits/java9, so you may look into that.

As you find issues, we can collaborate here. Once the local build is working on 9 and 11, we will configure a new build on Travis.

lpld · 2018-10-24T19:23:28Z

Great, thanks. I will keep you informed then.
What's the reason for getting the build to work on 9 first? Is it because you've already done some work on it?

ipolevoy · 2018-10-24T20:07:41Z

@lpld simply showing you what changes you may need to make on the 11.

lpld · 2018-10-24T20:25:51Z

Ahh I see. I thought you wanted to do it in some kind of incremental way: Java 9, then Java 11. Ok, so I will post my updates here as I move on.

ipolevoy · 2018-10-24T20:50:02Z

@lpld 👍

lpld · 2018-10-25T15:37:37Z

Stuck for now. Maven plugin-plugin uses maven-plugin-tools (latest version is 3.5.2), which in turn uses ASM 5. ASM starts supporting Java 11 from version 7 and is now only in beta. Thought I could trick plugin-tools by specifying ASM 7-beta dependency directly, but it turns out that plugin-tools specify ASM api version in the code: https://github.com/apache/maven-plugin-tools/blob/maven-plugin-tools-3.5.2/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/visitors/MojoAnnotationVisitor.java

super( Opcodes.ASM5 );

So it fails even with ASM 7. Looks like we'll have to wait until maven-plugin-tools 3.6.0 is out.

And maybe it was a good idea to start incrementally, from Java 9 :)

ipolevoy · 2018-10-25T16:19:56Z

haha, maybe. However, that -brings more complexities. Some people will stay on the v8 for a long time, meaning we will have to support all features and bugs in multiple branches and have multiple Travis builds for different versions of JavaLite. This is one reason why we stopped at v8 for now.

lpld · 2018-10-25T17:01:43Z

Agree. Let's wait for ASM 7 and maven-plugin-tools releases then. Will see how it builds after that.

ipolevoy · 2018-10-25T17:57:17Z

👍

lpld · 2018-10-30T20:37:50Z

Just saw the news: ASM 7.0 released
https://asm.ow2.io/
Looks like maven-plugin-tools did too (according to their github), but I can't still find them in maven-central. Probably have to wait a bit.

ipolevoy · 2018-10-30T20:48:13Z

when I release new versions of JavaLite, it takes a day/two for them to show on Maven central

jacktang · 2019-05-09T06:56:42Z

Hello, does 2.3-20190203.171650-13 snapshot support jdk11?
I got the below error

java.lang.ClassFormatError: Nest member class_info_index 14 has bad constant type in class file app/models/Case
	at java.base/java.lang.ClassLoader.defineClass1(Native Method)
	at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1016)
	at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:151)

The compiler:

            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-compiler-plugin</artifactId>
                <version>3.8.0</version>
                <configuration>
                    <release>11</release>
                </configuration>
            </plugin>

jacktang · 2019-05-09T08:20:10Z

2.3-SNAPSHOT works great 👍

ipolevoy · 2019-05-09T23:10:44Z

@jacktang you got lucky, we are not yet supporting Java 11 officially. Will be soon though!

pguillardp · 2019-05-16T12:34:34Z

Will be soon though!
clever! Good new! 2.3-SNAPSHOT works well. Thank you jacktang.
Igor, keep up the good work. Activejdbc is OUTSTANDING!!!!!!!!!!!

jacktang · 2019-05-16T14:33:24Z

@ipolevoy FormItem has some bugs on JDK11.

isFile() return false when the FormItem is multi-part
Can't get other normal form items.
I rolled back to JDK1.8 ...

ipolevoy · 2019-05-16T16:59:27Z

@jacktang , we will be releasing the 2.3 version in the next week/two and after that, will be migrating to Java 11 for 2.4 release.

npmarrin · 2019-06-05T20:58:55Z

@ipolevoy what is the current timeline for 2.3 and 2.4?

ipolevoy · 2019-06-05T22:13:15Z

@npmarrin we are working to restore the Travis build which broke for some reason. When that is done (@jfcabral promises this weekend), we will focus on releasing 2.3. After that, we will set a new snapshot version 3.0-SNAPSHOT (not 2.4) and focus on Java 11 support. I hope we can do both before mid-July.

npmarrin · 2019-06-06T05:39:24Z

@ipolevoy 👍

jamesmarcjon · 2019-07-09T21:37:58Z

@ipolevoy just checking in, curious if you are still generally on track with 2.4 for mid July or sooner?

ipolevoy · 2019-07-09T22:01:29Z

we just released 2.3 and will be working on releasing 3.0 on Java 11m however that work will start some tine this week, so hard to tell, but we are shooting for end of July at least.

ipolevoy · 2019-07-22T18:37:34Z

Hey guys, good news. The Java11 support is around the corner. The first snapshot is published: https://oss.sonatype.org/content/repositories/snapshots/org/javalite/activejdbc/3.0-SNAPSHOT/.
Please, take it for a spin and see if this is working for you. This was pushed out directly from my dev box.
The Travis build is being taken care of too, so once this is complete: #870, you will have a 3.0-SNAPSHOT regularly updated in the snapshot repo.

Can you please take this shanshot for a spin and let me know if it resolves this issue, so I could close it.

ipolevoy · 2019-07-23T22:46:09Z

@lpld I will be closing this issue in lieu of my comment above #803 (comment) and #869. If you run into problems, you can reopen this issue or open a new one.

ipolevoy closed this as completed Jul 23, 2019

ipolevoy added the Module: ActiveJDBC label Nov 6, 2019

ipolevoy added the Module: ActiveWeb label Nov 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ClassLoader cannot load model classes under OpenJDK 11. Is Java 11 even supported? #803

ClassLoader cannot load model classes under OpenJDK 11. Is Java 11 even supported? #803

lpld commented Oct 24, 2018

ipolevoy commented Oct 24, 2018

lpld commented Oct 24, 2018

ipolevoy commented Oct 24, 2018

lpld commented Oct 24, 2018

ipolevoy commented Oct 24, 2018

lpld commented Oct 24, 2018

ipolevoy commented Oct 24, 2018

lpld commented Oct 24, 2018 •

edited

ipolevoy commented Oct 24, 2018

lpld commented Oct 25, 2018

ipolevoy commented Oct 25, 2018

lpld commented Oct 25, 2018

ipolevoy commented Oct 25, 2018

lpld commented Oct 30, 2018

ipolevoy commented Oct 30, 2018

jacktang commented May 9, 2019 •

edited

jacktang commented May 9, 2019

ipolevoy commented May 9, 2019

pguillardp commented May 16, 2019

jacktang commented May 16, 2019

ipolevoy commented May 16, 2019

npmarrin commented Jun 5, 2019

ipolevoy commented Jun 5, 2019

npmarrin commented Jun 6, 2019

jamesmarcjon commented Jul 9, 2019

ipolevoy commented Jul 9, 2019

ipolevoy commented Jul 22, 2019 •

edited

ipolevoy commented Jul 23, 2019

ClassLoader cannot load model classes under OpenJDK 11. Is Java 11 even supported? #803

ClassLoader cannot load model classes under OpenJDK 11. Is Java 11 even supported? #803

Comments

lpld commented Oct 24, 2018

ipolevoy commented Oct 24, 2018

lpld commented Oct 24, 2018

ipolevoy commented Oct 24, 2018

lpld commented Oct 24, 2018

ipolevoy commented Oct 24, 2018

lpld commented Oct 24, 2018

ipolevoy commented Oct 24, 2018

lpld commented Oct 24, 2018 • edited

ipolevoy commented Oct 24, 2018

lpld commented Oct 25, 2018

ipolevoy commented Oct 25, 2018

lpld commented Oct 25, 2018

ipolevoy commented Oct 25, 2018

lpld commented Oct 30, 2018

ipolevoy commented Oct 30, 2018

jacktang commented May 9, 2019 • edited

jacktang commented May 9, 2019

ipolevoy commented May 9, 2019

pguillardp commented May 16, 2019

jacktang commented May 16, 2019

ipolevoy commented May 16, 2019

npmarrin commented Jun 5, 2019

ipolevoy commented Jun 5, 2019

npmarrin commented Jun 6, 2019

jamesmarcjon commented Jul 9, 2019

ipolevoy commented Jul 9, 2019

ipolevoy commented Jul 22, 2019 • edited

ipolevoy commented Jul 23, 2019

lpld commented Oct 24, 2018 •

edited

jacktang commented May 9, 2019 •

edited

ipolevoy commented Jul 22, 2019 •

edited