order associations #1034
Open
order associations #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasonsychau I will review later. However, I already see these issues:
Once I review the code, I will provide more insight. thank you |
|
@jasonsychau did you have a chance to look at the above? Can you please add tests that cover the new functionality. Also, please see the history of commits, the messages have a format - can you please follow that? |
|
Sure, I'll report when I have done it. |
|
@jasonsychau not only you may put down your name as an author, but you should :) ! |
|
@jasonsychau seems this has been sitting there for a while. Did you have a chance to look into it? |
|
Sorry, I’ve been busy. I can look into it on the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first attempt to address #844
May I have a review?
May I put down my name as an author?