Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Route.java #1047

Merged
merged 2 commits into from Sep 2, 2020
Merged

Update Route.java #1047

merged 2 commits into from Sep 2, 2020

Conversation

mppfiles
Copy link
Contributor

adding some message when responding with HTTP 405 (fixes #1046 ).

adding some message when responding with HTTP 405.
@ipolevoy
Copy link
Member

ipolevoy commented Sep 2, 2020

@mppfiles seems there is no test for the case? Can you please add one? Just follow some examples here: https://github.com/javalite/javalite/tree/master/activeweb/src/test/java/org/javalite/activeweb

edit test to match response message
@mppfiles
Copy link
Contributor Author

mppfiles commented Sep 2, 2020

There you go. Indeed, I just updated the existing one.

@ipolevoy ipolevoy merged commit 0943986 into javalite:master Sep 2, 2020
@ipolevoy
Copy link
Member

ipolevoy commented Sep 2, 2020

Merged. I missed the commit format. Should have been:

#1046 [ActiveWeb] Show some message on 405 errors 

this is a comment format we use to refer to the issues. I wonder if there is a way still to change the last commit?

@ipolevoy
Copy link
Member

ipolevoy commented Sep 2, 2020

I will wait porting to java8 for now

@mppfiles
Copy link
Contributor Author

mppfiles commented Sep 2, 2020

Merged. I missed the commit format. Should have been:

#1046 [ActiveWeb] Show some message on 405 errors 

this is a comment format we use to refer to the issues. I wonder if there is a way still to change the last commit?

I just force-pushed the last commit to amend its message. Maybe you can just cherry-pick it or something.

@ipolevoy
Copy link
Member

ipolevoy commented Sep 2, 2020

Github is weird, nothing happened there: https://github.com/javalite/javalite/commits/master, any idea?

@mppfiles
Copy link
Contributor Author

mppfiles commented Sep 3, 2020

Try with pulls/1048 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ActiveWeb] Show some message on 405 errors
2 participants