#874 Fix build in failure due to dokka-maven-plugin on JDK 11 #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took out the dokka-maven-plugin from the Maven's
packagephase to set it to thepre-sitephase to fix the main issue. Because the last version of this plugin is not working well with JDK 11 their is still both warnings and errors when you execute themvn sitecommand but beside that everything is generated correctly.Note that I have to upgrade the Kotlin version to the 1.3.50 in order to be able to make the Kotlin's compiler targeting JDK 11 and not only JDK 1.6 and 1.8. This will help in future releases.