Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting of numbers is based on String comparison in German #117

Closed
GoogleCodeExporter opened this issue Jun 21, 2015 · 2 comments
Closed

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Select a table header of execution time to sort it 

What is the expected output? What do you see instead?
The execution time should be sorted in ascending or descending order. 
But for ascended sorting is 2 ms > 1.000 ms
I checked it in the code and saw that it is using String comparison in 
Javascript (sorry it's a while ago when I did it).


What version of the product are you using? On what application server, JDK,
operating system?
Linux, JBoss, Javamelody 1.28.0

Please provide any additional information below.

First of all: Java melody is a great tool and we improved greatly in our 
project because we use it!

Original issue reported on code.google.com by mobil...@gmail.com on 22 Jun 2011 at 7:20

Attachments:

@GoogleCodeExporter
Copy link
Author

Thanks for the issue.
I have reproduced it using German [de] in the browser.
The cause is the '.' for the German thousand separator: it is considered as a 
US decimal separator by the javascript library.

The fix will be to remove '.' in the sort_numeric method.

Original comment by evernat@free.fr on 23 Jun 2011 at 11:58

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

I have committed the fix in trunk of svn in the javascript library (revision 
1915) and it is ready for the next release (1.30).

And I have made a new build from the current trunk and it is available at:
http://javamelody.googlecode.com/files/javamelody-20110625.jar

Original comment by evernat@free.fr on 24 Jun 2011 at 11:39

  • Changed title: Sorting of numbers is based on String comparison in German
  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant