Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datadog integration non-functional due to invalid JSON #701

Closed
bluegaspode opened this issue Dec 8, 2017 · 3 comments
Closed

Datadog integration non-functional due to invalid JSON #701

bluegaspode opened this issue Dec 8, 2017 · 3 comments

Comments

@bluegaspode
Copy link
Contributor

The current datadog integration is non-functional.

The generated JSON looks like the following, a colon is missing between array entries:

{ "series" : [
{"metric":"javamelody.usedMemory","points":699794512.00,"host":"Stefans-MBP","tags":["application":"/"]}
{"metric":"javamelody.cpu","points":0.00,"host":"Stefans-MBP","tags":["application":"/"]}
]}

The leads to exceptions from datadog like the following:

Error connecting to Datadog (400): Payload is not in the expected format: invalid character ':' after array element

@bluegaspode
Copy link
Contributor Author

in addition the "tags" entry is also not valid JSON.
Datadog expects an array of strings like
"tags":["application:/"]

@bluegaspode
Copy link
Contributor Author

bluegaspode commented Dec 8, 2017

um, did anyone actually tested it against datadog?

the "points" entry, needs to be an array with timestamp (in seconds) and data.

So a metric accepted by datadog looks like this:
{"metric":"javamelody.usedMemory","points":[[1512751139,704774344.00]],"host":"Stefans-MBP","tags":["application:/"]},

@evernat
Copy link
Member

evernat commented Dec 8, 2017

Unfortunately, I do not have a test account (I have looked at web site and it's not clear what I can do with a free account). And it seems that I have overlooked and/or misunderstood some points in the doc as it was written at that time. Sorry.
But fortunately, your PR #702 is merged in master now.
You can download a snapshot including the PR at:
https://javamelody.ci.cloudbees.com/job/javamelody/net.bull.javamelody$javamelody-core/
Thanks.

@evernat evernat closed this as completed Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants