Make sure open returns boolean #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muan
changed the title
javan
requested changes
Mar 7, 2018
| @@ -35,6 +35,8 @@ polyfillProperties = -> | |||
|
|
|||
| Object.defineProperties prototype, | |||
| open: | |||
| get: -> | |||
| @hasAttribute("open") | |||
There was a problem hiding this comment.
Since prototype might be HTMLUnknownElement (instead of HTMLDetailsElement when supported natively), we need to check if tagName is DETAILS and make sure to call the original geter. Just like the seter does.
|
Thank you! Made a tiny tweak in dc624c8 and published 2.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets
getfor theopenproperty and test to make sure it works.cc @javan