Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make it work with ActiveSupport >= 2.3.2 instead of >= 2.3.4 #217

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants

No description provided.

+ - jruby-head
+gemfile:
@javan

javan Mar 12, 2012

Owner

Neat! Didn't know Travis could do that.

@@ -130,7 +130,7 @@ def cron_jobs
Whenever::Output::Cron.output(time, job) do |cron|
cron << "\n\n"
- if cron.starts_with?("@")
+ if cron.start_with?("@")
@javan

javan Mar 12, 2012

Owner

Oh man, start_with reads like broken english. I think I'd rather just use a regex here.

@JonathanTron

JonathanTron Mar 12, 2012

Indeed, but this method exists in both ruby 1.8.7 and 1.9.x without having to require 'active_support/core_ext'.
If you want I can change it.

@javan javan closed this Aug 21, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment