Fix host with multiple role capistrano deployment #281
Conversation
Bug described here: javan#266 When a host belongs to multiple roles which have separate cron tasks associated, the last role specified in whenever_roles overwrites the previous crontab. Fix is to write crontab one host at a time, generating all roles for that host
| role_arg = " --roles #{role}" | ||
| end | ||
| server_roles_map.each do |server, roles| | ||
| roles_arg = "" # empty for begin |
There was a problem hiding this comment.
Is setting this empty string necessary now that you have the line to follow?
|
Thanks for working on this! I would LOVE it if you could add a comment or two. Future developers will thank you. cc @cap10morgan |
|
Comment to the README? |
|
In recipes.rb |
|
Thanks for working on this, @ajwalters. We need some tests around this functionality. I'm working on that locally and will issue a pull request once it's ready. There are a few tricky backwards compatibility issues here. |
|
Yeah, I tried to look into testing this but it seemed as if the capistrano integration lacked any tests. Not saying that's a good thing, but seemed like a larger refactoring to make the Capistrano integration more testable. Is this the approach you're taking? |
|
@ajwalters Similar to that, yes. Since we're using Test::Unit here instead of RSpec, the testing library mentioned in that post isn't applicable. But I am pulling the code out of recipe.rb and defining a separate, testable module that it will include instead. |
|
❤️ |
Bug described here: #266
When a host belongs to multiple roles which have separate cron tasks
associated, the last role specified in whenever_roles overwrites the
previous crontab.
Fix is to write crontab one host at a time, generating all roles for
that host