Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ArgumentError for 0 dates #17

Closed
wants to merge 1 commit into from

Conversation

andygeers
Copy link

If a DOS Time is 0, it raised an ArgumentError. This fixes it to behave the same as a nil time.

@javanthropus
Copy link
Owner

The way I solved this was to fix the incorrect method call that was triggered when a nil was passed to the DOSTime initializer. Passing a zero value is considered an attempt to pass a valid structure to the initializer, but this will fail now since that structure contains elements that are out of range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants