Merge pull request #2151 from jjbr/endless-recursion-parent-of-simila…

…r-name

Fix for endless recursion bug #2150

javaparser-symbol-solver-core/src/main/java/com/github/javaparser/symbolsolver/javaparsermodel/declarations/JavaParserInterfaceDeclaration.java

@@ -364,9 +364,6 @@ private ResolvedReferenceType toReferenceType(ClassOrInterfaceType classOrInterf
         if (ref == null || !ref.isSolved()) {
             ref = solveType(typeName);
         }
-        if (!ref.isSolved() && classOrInterfaceType.getScope().isPresent()) {
-            ref = solveType(classOrInterfaceType.getName().getId());
-        }
         if (!ref.isSolved()) {
             throw new UnsolvedSymbolException(classOrInterfaceType.getName().getId());
         }

javaparser-symbol-solver-testing/src/test/java/com/github/javaparser/symbolsolver/resolution/NotQuiteCyclicParentTest.java

@@ -0,0 +1,36 @@
+package com.github.javaparser.symbolsolver.resolution;
+
+import com.github.javaparser.ast.CompilationUnit;
+import com.github.javaparser.ast.body.ClassOrInterfaceDeclaration;
+import com.github.javaparser.ast.body.MethodDeclaration;
+import com.github.javaparser.ast.expr.VariableDeclarationExpr;
+import com.github.javaparser.ast.stmt.ExpressionStmt;
+import com.github.javaparser.resolution.UnsolvedSymbolException;
+import com.github.javaparser.resolution.types.ResolvedType;
+import com.github.javaparser.symbolsolver.javaparser.Navigator;
+import com.github.javaparser.symbolsolver.javaparsermodel.JavaParserFacade;
+import com.github.javaparser.symbolsolver.resolution.typesolvers.ReflectionTypeSolver;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.fail;
+
+public class NotQuiteCyclicParentTest extends AbstractResolutionTest {
+
+	@Test
+	void testSimilarNameInterface() {
+		CompilationUnit cu = parseSample("NotQuiteCyclicParent");
+		ClassOrInterfaceDeclaration clazz = Navigator.demandInterface(cu, "NotQuiteCyclicParent");
+		MethodDeclaration method = Navigator.demandMethod(clazz, "main");
+		VariableDeclarationExpr varDec =
+				(VariableDeclarationExpr) ((ExpressionStmt) method.getBody().get().getStatement(0)).getExpression();
+
+		try {
+			ResolvedType ref = JavaParserFacade.get(new ReflectionTypeSolver()).getType(varDec);
+		} catch (UnsolvedSymbolException e) {
+			return;
+		}
+
+		fail("We shouldn't be able to resolve the type (it is not defined).");
+	}
+
+}

javaparser-symbol-solver-testing/src/test/resources/NotQuiteCyclicParent.java.txt

@@ -0,0 +1,7 @@
+package foo;
+
+public interface NotQuiteCyclicParent extends bar.NotQuiteCyclicParent {
+    default void main() {
+        MyType x = new MyType();
+    }
+}