Add additional tests for double conversion - #663

javaparser · Mar 17, 2017 · 3a2bd64 · 3a2bd64
1 parent 7c4b33a
commit 3a2bd64
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/javaparser-core/src/main/java/com/github/javaparser/ast/expr/DoubleLiteralExpr.java b/javaparser-core/src/main/java/com/github/javaparser/ast/expr/DoubleLiteralExpr.java
@@ -22,10 +22,10 @@
 
 import com.github.javaparser.Range;
 import com.github.javaparser.ast.AllFieldsConstructor;
-import com.github.javaparser.ast.visitor.GenericVisitor;
-import com.github.javaparser.ast.visitor.VoidVisitor;
 import com.github.javaparser.ast.Node;
 import com.github.javaparser.ast.visitor.CloneVisitor;
+import com.github.javaparser.ast.visitor.GenericVisitor;
+import com.github.javaparser.ast.visitor.VoidVisitor;
 import com.github.javaparser.metamodel.DoubleLiteralExprMetaModel;
 import com.github.javaparser.metamodel.JavaParserMetaModel;
 

diff --git a/...rser-testing/src/test/java/com/github/javaparser/ast/expr/LiteralStringValueExprTest.java b/...rser-testing/src/test/java/com/github/javaparser/ast/expr/LiteralStringValueExprTest.java
@@ -21,6 +21,7 @@
 package com.github.javaparser.ast.expr;
 
 import com.github.javaparser.JavaParser;
+import org.assertj.core.data.Percentage;
 import org.junit.Test;
 
 import static org.assertj.core.api.Assertions.assertThat;
@@ -75,9 +76,15 @@ public void charLiteralsAreConverted() {
 
     @Test
     public void doubleLiteralsAreConverted() {
-        DoubleLiteralExpr literalExpr = new DoubleLiteralExpr(25.0d);
+        DoubleLiteralExpr posFloat = JavaParser.parseExpression("3.4028235e38f");
+        DoubleLiteralExpr negFloat = JavaParser.parseExpression("1.40e-45f");
+        DoubleLiteralExpr posDouble = JavaParser.parseExpression("1.7976931348623157e308");
+        DoubleLiteralExpr negDouble = JavaParser.parseExpression("4.9e-324");
 
-        assertThat(literalExpr.asDouble()).isEqualTo(25.0d);
+        assertThat(posFloat.asDouble()).isCloseTo(3.4028235e38f, Percentage.withPercentage(1));
+        assertThat(negFloat.asDouble()).isCloseTo(1.40e-45f, Percentage.withPercentage(1));
+        assertThat(posDouble.asDouble()).isEqualTo(1.7976931348623157e308);
+        assertThat(negDouble.asDouble()).isEqualTo(4.9e-324);
     }
 
 }