Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LexicalPreservingPrinter Difference Algorithm breaks indentation after adding identical statements. #2203

Closed
moraispgsi opened this issue Apr 28, 2019 · 1 comment
Closed

LexicalPreservingPrinter Difference Algorithm breaks indentation after adding identical statements. #2203

moraispgsi opened this issue Apr 28, 2019 · 1 comment
Labels
Bug report help wanted Lexical Preservation

Comments

@moraispgsi
Copy link
Contributor

moraispgsi commented Apr 28, 2019 •
edited

When using the LexicalPreservingPrinter, adding a statement identical to the previous statement breaks the Difference Algorithm because it confuses it, it makes it believe that the first statement was the one that was added, as a consequence the indentation breaks.

Will be submitting a PR for this with a test case.
@moraispgsi moraispgsi changed the title Adding an IfStmt to a method should add indentation LexicalPreservingPrinter Difference Algorithm breaks indentation after adding identical statements. Apr 28, 2019
moraispgsi added a commit to TQRG/javaparser that referenced this issue Apr 28, 2019
@moraispgsi
Tests for javaparser#2203
2f6049a
@moraispgsi moraispgsi mentioned this issue Apr 28, 2019
Closed
matozoid added a commit to TQRG/javaparser that referenced this issue Sep 18, 2019
@matozoid
Merge branch 'master' into javaparser#2203
215466b
matozoid added a commit to TQRG/javaparser that referenced this issue Jan 5, 2020
@matozoid
Merge branch 'master' into javaparser#2203
66edf42
MysterAitch added a commit to TQRG/javaparser that referenced this issue Apr 19, 2020
@MysterAitch
Merge branch 'master' into javaparser#2203
7e32658
MysterAitch added a commit to TQRG/javaparser that referenced this issue Nov 14, 2020
@MysterAitch
Merge branch 'master' into javaparser#2203
379144f
@jlerbsc
Copy link
Collaborator

jlerbsc commented Nov 22, 2022

I close this issue because actually all these tests pass int the current version.

@jlerbsc jlerbsc closed this as completed Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug report help wanted Lexical Preservation
Projects
None yet
Milestone
No milestone
3 participants
@matozoid @jlerbsc @moraispgsi