Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceRoot.tryToParse() fails if the root path ends with a directory that is not a java identifier #3489

Closed
stumpedatwork opened this issue Feb 8, 2022 · 0 comments · Fixed by #3551
Milestone

Comments

@stumpedatwork
Copy link

stumpedatwork commented Feb 8, 2022

Hey, just a heads up

new SourceRoot("tests/01").tryToParse() causes isSensibleDirectoryToEnter() to skip the subtree and return zero CompilationUnit.

Thank you for being such awesome coders and people!

jlerbsc added a commit that referenced this issue Apr 11, 2022
Fix issue #3489 SourceRoot.tryToParse() fails if the root path ends with a directory that is not a java identifier
@MysterAitch MysterAitch added this to the next release milestone Apr 17, 2022
wadoon added a commit to jmltoolkit/jmlparser that referenced this issue May 23, 2022
# By Renovate Bot (21) and others
# Via GitHub (26) and jlerbsc (2)
* upstream/master: (48 commits)
  Simplify range tests
  Add methods isBefore and isAfter to simplify token range testing
  fix(deps): update dependency org.javassist:javassist to v3.29.0-ga
  chore(deps): update dependency org.codehaus.mojo:versions-maven-plugin to v2.11.0
  chore(deps): update dependency org.jbehave:jbehave-core to v4.8.3
  chore(deps): update actions/checkout action to v3.0.2
  Fix issue javaparser#2042 PACKAGE_PRIVATE should be renamed to DEFAULT or NONE
  chore(deps): bump codecov/codecov-action from 3.0.0 to 3.1.0
  chore(deps): update dependency org.mockito:mockito-inline to v4.5.1
  chore(deps): update dependency org.apache.maven.plugins:maven-site-plugin to v3.12.0
  chore(deps): update dependency org.apache.maven.plugins:maven-javadoc-plugin to v3.4.0
  chore(deps): update dependency org.mockito:mockito-inline to v4.5.0
  chore(deps): update codecov/codecov-action action to v3
  chore(deps): update actions/checkout action to v3.0.1
  official Apache Maven wrapper
  chore(deps): update dependency org.jacoco:jacoco-maven-plugin to v0.8.8
  Fix issue javaparser#3489 SourceRoot.tryToParse() fails if the root path ends with a directory that is not a java identifier
  Migrate from mockito-core to mockito-inline to support static mocking
  chore(deps): update dependency org.apache.maven.plugins:maven-clean-plugin to v3.2.0
  chore(deps): update dependency org.apache.maven.plugins:maven-surefire-plugin to v3.0.0-m6
  ...

# Conflicts:
#	.github/workflows/maven_tests.yml
#	FEATURES.md
#	javaparser-core-generators/pom.xml
#	javaparser-core-metamodel-generator/pom.xml
#	javaparser-core-serialization/pom.xml
#	javaparser-core-testing-bdd/pom.xml
#	javaparser-core-testing/pom.xml
#	javaparser-core/pom.xml
#	javaparser-core/src/main/java/com/github/javaparser/ParserConfiguration.java
#	javaparser-symbol-solver-core/pom.xml
#	javaparser-symbol-solver-testing/pom.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants