Some few fixes and enhancements #1
Conversation
Some few fixes and enhancements
|
Thank you :) |
|
No, thank you :) On Sun, Apr 1, 2012 at 1:46 AM, ptitjes
|
|
If you wish, I have a variant of DumpVisitor that respects blank lines from the input. It follows Node.getBeginLine, and getEndLine to determine if there were some blank lines between non-modified nodes that were in the original tree. I also have some type-checking (expected and actual type) stuff, although it is not implemented for all kind of expressions yet. It could be optimized by introducing a "feature" attribute in addition to parentNode to know in which property and index (for lists) of its parent node it is located. (I would only have to add that to the setAsParentNodeOf() method). Tell me what you think about it. |
|
I've added you to the collaborator list. Add any features you like :-) I'll also add some issues to the issue tracker here. |
|
Great :) |
Update VoidVisitorAdapter.java
draft of CSM for the Module Info nodes
Align to RuleUnit and add example using maven build system.
Parse OOPath expression
Specifically, this PR adds the following: * A node structure that mirrors the Javadoc custom parser structure (JavadocDescription, JavadocBlockTag, JavadocDescriptionElement, JavadocSnippet and JavadocInlineTag); * An integration to the overall node structure including the Meta Model; * Relevant unit tests that are translated from the custom javadoc parser. Tests related to the parsing will be added with the grammar. The PR does not implement the following due to time constraints: * Pretty Printing; * Concrete Syntax Model Support; * Full integration by replacing JavadocComment with JavadocContent in the AST. Instead, we simply created another node called JavadocContent. Co-authored-by: David Johansson <david.johansson11@gmail.com>
Add missing test case for Log.error(Throwable)
…-java/switch-literal-first Switch order of literals to prevent NullPointerException
I reintroduced ASTHelper class, fix the parent management (it was not propagating correctly and there was a lot of replicated code so I factored the parent setting code), and GenericProviderVisitor was not returning the return values correctly.