Fix issue #2374 Comments of added Nodes are ignored in LexicalPreserv… #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matozoid
reviewed
Oct 4, 2019
| // In this case keyworld [class] is considered as a token and [A] is a child element | ||
| // So if we don't care that the node is an ExpressionStmt we could try to generate a wrong definition | ||
| // like this [class // This is my class, with my comment A {}] | ||
| if (node.getComment().isPresent() && node instanceof ExpressionStmt) { |
There was a problem hiding this comment.
What is the defining characteristic of nodes like ExpressionStmt that make them need behaviour like this? Maybe we can make that a property of the node, so we can avoid node specific exceptional logic here.
There was a problem hiding this comment.
I think it's more specific to lexical printer than expression statement.
There was a problem hiding this comment.
Okay, but do you think there are other nodes likes this? If not, it's okay.
There was a problem hiding this comment.
Sincerely, I don't know! I don't know enough JavaParser to answer this question. Maybe the author could answer it.
There was a problem hiding this comment.
Let's just merge it then :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ingPrinter
Fixes #2374 .