Reduce amount of symbol solver jars #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Can I get some feedback on this? |
|
No specific objections from me. My only two comments are just what was said on chat re: double checking that this is the only place we have packages duplicated across modues, and whether we should take this as a good time/opportunity to review the module structure more generally. They can both be done as incremental updates though, no need to block this PR from being included in the next release. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2563.
As it seems that nobody knows why the symbols solver is split into three jars, nobody really kept the split clean, and the split is causing trouble with modules (see issue), this PR merges everything into the core jar.