Fix resolving super methodcalls in anonymous inner classes (fixes #1962) #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to be good, with JLS 15.9 (specifically 15.9.5), though I do add the caveat that I don't fully understand it all 😅 https://docs.oracle.com/javase/specs/jls/se11/html/jls-15.html#jls-15.9 I'm marking this as being for the next release, but will leave the PR open for a short while just in case there is any additional comment to add. |
…ingTypeDeclOrObjectCreationExpr()` to explain the distinction between the two.
…types (inconsistent use of fully-qualified and simple names)
|
Just added some documentation to the pr to help explain the difference between the two methods. Please do feel free to edit / revert these commits if you wish (I'll not be offended!), and instead I'll include them in a separate PR. |
MysterAitch
added a commit
to MysterAitch/javaparser
that referenced
this pull request
Apr 5, 2020
javaparser#1949 ``` Solving at MyClass (line 7,col 9): doSomething Error :( UnsolvedSymbolException{context='null', name='We are unable to find the method declaration corresponding to MyInterface.super.doSomething()', cause='null'} at com.github.javaparser.symbolsolver.JavaSymbolSolver.resolveDeclaration(JavaSymbolSolver.java:167) at com.github.javaparser.ast.expr.MethodCallExpr.resolve(MethodCallExpr.java:313) at com.github.javaparser.symbolsolver.Issue1949Test.testReflectionFirst(Issue1949Test.java:53) ```
|
looks good, thx! :-) |
|
In that case, let's kick-off the merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1962 .