Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding method descriptor resolution #2976

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Adding method descriptor resolution #2976

merged 1 commit into from
Dec 14, 2020

Conversation

jlerbsc
Copy link
Collaborator

@jlerbsc jlerbsc commented Dec 14, 2020

Fixes #2059 .
https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.3.3
The method descriptor for the method:

 Object m(int i, double d, Thread t) {...}

is

(IDLjava/lang/Thread;)Ljava/lang/Object;

Note that the internal forms of the binary names of Thread and Object are used.

@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #2976 (255603d) into master (8fb6e42) will decrease coverage by 0.002%.
The diff coverage is 92.307%.

Impacted file tree graph

@@               Coverage Diff               @@
##              master     #2976       +/-   ##
===============================================
- Coverage     54.866%   54.864%   -0.003%     
  Complexity      2410      2410               
===============================================
  Files            602       602               
  Lines          33279     33295       +16     
  Branches        5596      5595        -1     
===============================================
+ Hits           18259     18267        +8     
- Misses         13172     13179        +7     
- Partials        1848      1849        +1     
Flag Coverage Δ Complexity Δ
AlsoSlowTests 54.864% <92.307%> (-0.003%) 0.000 <0.000> (ø)
javaparser-core 50.519% <38.461%> (-0.043%) 0.000 <0.000> (ø)
javaparser-symbol-solver 39.579% <92.307%> (+0.002%) 0.000 <0.000> (ø)
jdk-10 54.861% <92.307%> (-0.001%) 0.000 <0.000> (ø)
jdk-11 54.864% <92.307%> (+0.002%) 0.000 <0.000> (ø)
jdk-12 54.864% <92.307%> (+0.002%) 0.000 <0.000> (ø)
jdk-13 54.864% <92.307%> (+0.002%) 0.000 <0.000> (ø)
jdk-14 54.864% <92.307%> (+0.002%) 0.000 <0.000> (ø)
jdk-15 54.864% <92.307%> (+0.002%) 0.000 <0.000> (ø)
jdk-8 ? ?
jdk-9 54.864% <92.307%> (+0.002%) 0.000 <0.000> (ø)
macos-latest ? ?
ubuntu-latest 54.864% <92.307%> (+0.012%) 0.000 <0.000> (ø)
windows-latest ? ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../com/github/javaparser/ast/type/ReferenceType.java 15.000% <ø> (ø) 0.000 <0.000> (ø)
...main/java/com/github/javaparser/ast/type/Type.java 29.069% <0.000%> (-0.342%) 0.000 <0.000> (ø)
.../com/github/javaparser/ast/type/TypeParameter.java 37.313% <0.000%> (-0.566%) 0.000 <0.000> (ø)
.../github/javaparser/ast/body/MethodDeclaration.java 68.141% <100.000%> (+2.103%) 0.000 <0.000> (ø)
...java/com/github/javaparser/ast/type/ArrayType.java 85.393% <100.000%> (+0.687%) 0.000 <0.000> (ø)
...thub/javaparser/ast/type/ClassOrInterfaceType.java 58.163% <100.000%> (+0.431%) 0.000 <0.000> (ø)
.../com/github/javaparser/ast/type/PrimitiveType.java 63.636% <100.000%> (+1.136%) 0.000 <0.000> (ø)
.../java/com/github/javaparser/ast/type/VoidType.java 48.000% <100.000%> (+2.166%) 0.000 <0.000> (ø)
.../resolution/typesolvers/ClassLoaderTypeSolver.java 76.470% <0.000%> (-5.883%) 10.000% <0.000%> (ø%)
...urces/com/github/javaparser/TokenMgrException.java 69.230% <0.000%> (-5.129%) 0.000% <0.000%> (ø%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fb6e42...255603d. Read the comment docs.

@jlerbsc
Copy link
Collaborator Author

jlerbsc commented Dec 14, 2020

We can get method descriptor from MethodDeclaration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method descriptor
2 participants