-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing overrides for ModifierVisitorAdapter #301
Conversation
It seems to not compile:
|
I think it makes sense but we should fix the return type of the second method |
Yeah, sorry about that. I fixed that and tried to add a test. Let me know if it doesn't meet the standards or is in the wrong place. This is my first time using JBehave. |
No problem, tests are there to help us catch these things :) |
|
||
public class ModifierVisitorAdapterTest { | ||
|
||
@Then("ModifierVisitorAdapter requires no overrides") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand what this test is doing. It instantiate an object and then it verifies it is not null?
Yes. The real test is that the construction compiles. If ModifierVisitorAdapter is missing any overrides like it was before this patch, then the construction will not compile. I added the assertion just so that the test has at least one. I'll make this test look however you want, just tell me. |
I would suggest we just remove the test and merge the change as it is. Thanks for your help on this one! |
As you wish. |
Looks perfect. Thanks again! |
…of_javassist_field fixed solving generic type of JavassistFieldDeclaration
Closes #300