Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #3030 NoSuchElementException when solving type #3031

Merged
merged 2 commits into from Jan 9, 2021

Conversation

4everTheOne
Copy link
Contributor

Fixes #3030.

Added unit test that was provided in the issue javaparser#3030.
Added safe checks for the optional parameters
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #3031 (0ca8963) into master (3392953) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3031   +/-   ##
=========================================
  Coverage   50.468%   50.468%           
=========================================
  Files          450       450           
  Lines        25105     25105           
  Branches      3794      3794           
=========================================
  Hits         12670     12670           
  Misses       11456     11456           
  Partials       979       979           
Flag Coverage Δ
AlsoSlowTests 50.468% <ø> (ø)
javaparser-core 50.468% <ø> (ø)
jdk-10 50.468% <ø> (ø)
jdk-11 50.468% <ø> (ø)
jdk-12 50.468% <ø> (ø)
jdk-13 50.468% <ø> (ø)
jdk-14 50.468% <ø> (ø)
jdk-15 50.468% <ø> (ø)
jdk-8 50.466% <ø> (ø)
jdk-9 50.468% <ø> (ø)
macos-latest 50.456% <ø> (ø)
ubuntu-latest 50.456% <ø> (ø)
windows-latest 50.456% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3392953...0ca8963. Read the comment docs.

@jlerbsc
Copy link
Collaborator

jlerbsc commented Jan 9, 2021

It seems like a reasonable and tested PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoSuchElementException when solving type
3 participants